Update command timeout (and all time-based parameters) to TimeSpan
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 18.4k
- Forks
- 3.7k
- Avg merge
- 5h 8m
- Merged PRs (30d)
- 1
Description
I suspect this should be grouped under #688 since this is a breaking change.
I've always hated how commandTimeout was typed as an int; .NET has always had an abstraction for time in the TimeSpan structure.
Exposing commandTimeout as a TimeSpan from Dapper would prevent the need for creating convenience wrappers and make readability/usability much better IMO.
Anecdotally, I have to look up the syntax every time I need to use commandTimeout as I can't remember if it's seconds or milliseconds.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing this issue alongside #688, then locate Dapper's commandTimeout and other time-based parameter entry points. The issue mentions no files or tests, so first map the affected API surface and determine the breaking-change scope. Done means the relevant parameters consistently use TimeSpan with the scope agreed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100