GetLiteralTokens slow with large command texts
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 18.4k
- Forks
- 3.7k
- Avg merge
- 5h 8m
- Merged PRs (30d)
- 1
Description
For a rarely used feature the overhead is really too big -- making up 7% of our response times -- and it's all spent in the regex engine.
Could this be placed behind a flag or in a DynamicParameters derived type?
If so I'm willing to PR it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating GetLiteralTokens and profiling the regex-engine path for large command texts. Done means agreeing on whether the work belongs behind a flag or in a DynamicParameters-derived type, then demonstrating that the reported overhead is reduced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100