DapperLib / DapperLib/Dapper

V2 API refactors

Open
#1,293 10 comments 29 reactions 1 assignee View on GitHub

@mgravell is already working on this.

Since Jul 11, 2019.

area:api breaking-change v3.0
Dominant language
C#
Stars
18.4k
Forks
3.7k
Avg merge
5h 8m
Merged PRs (30d)
1

Description

So v2 is going to have to happen at some point; we will want to do as much as we can at one "break", so: thoughts here:

Virtually definite

  • unify strong-name
  • remove overload-'splosion caused by gradual growth of overloads
  • move from IDbConnection etc to DbConnection for the async methods
  • make sure CancellationToken is used on all async methods
  • drop TFM support for netstandard1.3
  • remove the SqlClient dependency (need to fix one API only)

Virtually definite (additive; not a break)

  • new IAsyncEnumerable<T> API

Maybe

  • move from IDbConnection etc to DbConnection throughout
  • move from Task<T> to ValueTask<T> throughout
  • move the existing QueryAsync<T> API to IAsyncEnumerable<T> (was Task<IEnumerable<T>>)

Maybe (additive; not a break)

  • add TFM for netcoreapp3.0 and review what we can exploit
  • support for new ADO.NET batching API

Wouldn't rule it out (somewhere between "maybe" and "nope")

  • PooledAwait (internal implementation detail, but adds a dependency; works best with ValueTask<T>, but can have benefits on Task<T> too)

other ideas?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.