Identity.ForGrid shouldn't set parametersType to the new Identity
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 18.4k
- Forks
- 3.7k
- Avg merge
- 5h 8m
- Merged PRs (30d)
- 1
Description
In Identity.ForGrid, it'd better to pass null as parametersType when creating new Identity, so that in SqlMapper.GetCacheInfo, it won't try to find the paramReader. It seems that we don't need paramReader inside the GridReader
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read Dapper/SqlMapper.Identity.cs at Identity.ForGrid and trace how the resulting Identity reaches SqlMapper.GetCacheInfo in Dapper/SqlMapper.cs. Done means GridReader identities pass null for parametersType and GetCacheInfo no longer tries to find an unnecessary paramReader for them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100