DapperLib / DapperLib/Dapper.Contrib
Insert<TTEntity>(TEntity entity) should use GetType
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 293
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I answered this question today
https://stackoverflow.com/questions/55398454/how-to-instanciate-an-object-by-activator-createinstance-an-inserting-it-on-a-ta/55398570#55398570
He used object as generic argument. Which broke dapper. The reason why is becasue you do var type = typeof(T). The correct way would instead be var type = entity.GetType();
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Insert(TEntity entity) and inspect how the entity type is determined, especially the current typeof(T) usage. Reproduce the case where object is the generic argument and verify that insertion uses the entity's runtime type instead; done means that scenario no longer breaks Dapper.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100