DapperLib / DapperLib/Dapper.Contrib

Inconsistent return value for Insert/InsertAsync in Dapper Contrib

Open
#83 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
293
Forks
109
PR merge metrics
No merged PRs in 30d

Description

Is there a reason for InsertAsync returning int while Insert returns a long?

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the InsertAsync and Insert signatures at the linked locations in Dapper.Contrib/SqlMapperExtensions.cs and Dapper.Contrib/SqlMapperExtensions.Async.cs. Determine the intended consistent return type, then check the surrounding API usage and build to confirm the signatures are compatible.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.