DapperLib / DapperLib/Dapper.Contrib
Dapper.Contrib Insert returns long but InsertAsync returns int
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 293
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Description
In Dapper.Contrib the Insert method returns a long but InsertAsync returns an int. Could you have both returning the same for consistency please? I personally would prefer int (32 bits) but I understand some people might need long (64 bits).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Dapper.Contrib definitions and tests for Insert and InsertAsync, then compare their return types and usages. Confirm whether the consistent API should return int or long, update the affected declarations and expectations, and run the relevant test suite to verify both methods agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100