DapperLib / DapperLib/Dapper.Contrib
Insert always returns int. What about int64 id columns?
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 293
- Forks
- 109
- PR merge metrics
- No merged PRs in 30d
Description
This seems like a relatively small thing to fix. InsertAsync at the moment will always return int32, while Insert returns long. This will not work with tables, where the id happens to be int64.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate InsertAsync and compare its return type and behavior with Insert, which the issue identifies as returning long. Review the surrounding insert implementation and relevant existing tests, then verify that inserts using int64 identity columns return the expected value without regressing existing cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100