DapperLib / DapperLib/Dapper.Contrib

SQL Mapper Extensions GetFormatter returns incorrect adapter when using Transacted Connection

Open
#103 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
293
Forks
109
PR merge metrics
No merged PRs in 30d

Description

In the code below, the 'name' is set to TransactedConnection, which, naturally, does not have an entry in the AdapterDictionary, returning the default SQL Server adapter. Most likely, an exception is needed for a Transacted Connection getting the connection name from the Conn property of the Transacted Connection

` private static ISqlAdapter GetFormatter(IDbConnection connection)
{
var name = GetDatabaseType?.Invoke(connection).ToLower()
?? connection.GetType().Name.ToLower();

        return AdapterDictionary.TryGetValue(name, out var adapter)
            ? adapter
            : DefaultAdapter;
    }

`
This modified code seems to address this issue:

` private static ISqlAdapter GetFormatter(IDbConnection connection)
{
if (connection is TransactedConnection)
{
connection = ((TransactedConnection)(connection)).Connection;
}

        var name = GetDatabaseType?.Invoke(connection).ToLower()
                   ?? connection.GetType().Name.ToLower();

        return AdapterDictionary.TryGetValue(name, out var adapter)
            ? adapter
            : DefaultAdapter;
    }

`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the GetFormatter entry point shown in the issue and inspect how TransactedConnection exposes its underlying Connection. Verify adapter selection for a transaction-wrapped connection and add coverage for that case, with completion shown by the correct non-default adapter being selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.