DVMProject / DVMProject/pydvm

Auth/Re-Auth Logic Needs Improvement

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The logic for ensuring we don't duplicate auth token requests needs updating - currently if an auth exchange is already in progress, auth() just returns False which can lead to some undesired behavior in certain logic routines.

Ideally auth() would block until the auth exchange that's already in progress completes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the auth() entry point and the state used to track an in-progress auth exchange. Review the routines that call auth() when it returns False. Done means concurrent auth() calls avoid duplicate token requests and wait for the existing exchange to complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.