DUNE-DAQ / DUNE-DAQ/triggeralgs
Correct Conversion of TP Samples to Time
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 7
- Avg merge
- 2m
- Merged PRs (30d)
- 1
Description
The new TP format replaced time_over_threshold (TOT) with samples_over_threshold (SOT) and time_peak with samples_to_peak (STP). As a means to move on with the format change, various TA makers replaced references to TOT and time_peak by using a hard-coded conversion (* 32) from SOT to TOT and STP to time_peak.
Each of these conversions is marked with a FIXME comment and details on the problem, e.g., https://github.com/DUNE-DAQ/triggeralgs/blob/233b3e1393b7f28af017f521f2e9870a3c3af986/src/TAMakerADCSimpleWindowAlgorithm.cpp#L92
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the FIXME and hard-coded conversion in src/TAMakerADCSimpleWindowAlgorithm.cpp, then locate the other TOT and time_peak conversion sites described in the issue. Determine the correct SOT-to-TOT and STP-to-time_peak conversions, replace each marked workaround, and verify the affected trigger-algorithm behavior with the repository's available checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100