DUNE-DAQ / DUNE-DAQ/trigger

[Feature]: New and replacement integration / regression tests

Open
#428 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
0
Forks
8
Avg merge
7h 21m
Merged PRs (30d)
3

Description

Description

Two of the three existing integtests in the trigger repo are broken. This has been true for a while, and I am going to remove them, for now.

However, the functionality that they once tested would still be good to have. So, I'm filing this Issue to remind us to come back to these tests someday.

  • the tc_time_outside_window_test.py test attempts to validate the expected behavior of TriggerCandidate fragments when the TriggerDecision request window doesn't include the TC time. Unfortunately, at the moment, it is not clear to me how we expect TC fragments to be populated in various conditions, and I'm not sure of the current way (or ways) that we specify TC times versus other times.
  • the td_leakage_between_runs_test.py test attempted to validate the graceful stopping of TriggerDecision messages between the MLT and the DFO. There are comments in this this PR. The stumbling block to getting this integtest working again now is that it is not clear how we would configure the conditions that are likely to demonstrate the problem

In summary, it would be good to bring back these tests someday.

Independent of that, we can imagine other tests that would be useful. Such as ones that validate the behavior of TC merging.

Potential impact radius

Small/Isolated

Reason for change

Validating expected functionality is a good thing

Suggested implementations

No response

Testing suggestions

No response

Anything else?

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the removed or broken tc_time_outside_window_test.py and td_leakage_between_runs_test.py integration tests, then read the comments in PR 249. Clarify how TriggerCandidate fragments and TriggerDecision request windows are configured before restoring tests; done means the replacement regression tests run successfully, with any useful TC-merging coverage included.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.