TPReplay - ability to deal with PDS TPs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 21m
- Merged PRs (30d)
- 3
Description
Currently, the TPReplay application is set to filter out PDS TPs (as at the point of designing the application the flow/implementation of PDS TPs was unknown).
The way the filtering is applied:
- there is a defined set of valid subdetectors: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L76-L80
- TPs
detidis compared against this set, and filtered out if the detid is NOT in this set of valid subdetectors: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L336-L341 - same filter is of course part of the python part to prepare the confs:
To make the TPReplay app also work with PDS TPs:
- either add the PDS-related subdetector to the set
- think about the potential removal of the whole filtering logic at that point
One other important thing to mention:
Because replay expects TPC TPs only, it only creates the infrastructure to deal with those, as shown in the channel map here: https://github.com/DUNE-DAQ/trigger/blob/develop/plugins/TPReplayModule.cpp#L85. Therefore, one also needs to extend the infrastructure to the PDS TPs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with plugins/TPReplayModule.cpp, especially the valid-subdetector set, filtering around the referenced lines, and the channel map, then inspect the corresponding filtering in python/trigger/tpreplay_application/main.py. Done means TPReplay accepts PDS TPs and its infrastructure supports them alongside TPC TPs; resolve whether filtering should be extended or removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100