DUNE-DAQ / DUNE-DAQ/trigger

General refactoring of names for modules and configuration parameters

Open
#209 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
0
Forks
8
Avg merge
7h 21m
Merged PRs (30d)
3

Description

Some names in the trigger/triggeralgs repositories are now old / inaccurate. A good example of this is the Horizontal Muon Activity Maker, which is configurable to not only trigger on muons but can also look for adjacencies/multiplicities etc. Additional refactoring should be considered for the schema options for particular plugin/module to make it obvious what module/plugin the option in question belongs to. Example of this is trigger_window_before_ticks which only changes the timing TCs - which is not obvious from the name. Another one would be trigger_rate_hz.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing triggeralgs/src/TriggerActivityMakerHorizontalMuon.cpp and the linked entries in daqconf/config/daqconf_full_config.json. Trace how the module names and schema options are used across the trigger and triggeralgs repositories before defining the affected scope. Done requires an agreed, consistent naming scheme applied to the relevant modules and configuration parameters.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, distributed-systems
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.