DUNE-DAQ / DUNE-DAQ/snbmodules

[Bug]: Tests can't run because they import non-existent code

Open
#24 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
1
Forks
1
Avg merge
1m
Merged PRs (30d)
1

Description

Description

An example of what I'm talking about is if, given a set-up DUNE DAQ environment, you run:
pytest -s $SNBMODULES_SHARE/integtest/snb_1node_1app_rclone_http_system_quick_test.py
you'll see

/cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFD_DEV_260209_A9/spack-0.22.0/opt/spack/linux-almalinux9-x86_64/gcc-14.3.0/snbmodules-NFD_DEV_260209_A9-lf4vmddtwgjzfhsmzi526f6xa5c7ahg3/share/integtest/snb_1node_1app_rclone_http_system_quick_test.py:13: in <module>
    import integrationtest.config_file_gen as config_file_gen
E   ModuleNotFoundError: No module named 'integrationtest.config_file_gen'

and rather than pass or fail, the test simply won't execute. The reason is that it's trying to import code from integrationtest which used to exist (python/integrationtest/config_file_gen.py) but was removed in September right before v3.0.1 of integrationtest was cut. This test (and any others with similar problems) should be updated to account for last year's changes to integrationtest.

Steps to reproduce

[set up daq-buildtools as usual, then]

dbt-setup-release -n last_fddaq
pytest -s $SNBMODULES_SHARE/integtest/snb_1node_1app_rclone_http_system_quick_test.py
Version and environment

NFD_DEV_260209_A9

Impact

Small/Isolated

Anything else?

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with integtest/snb_1node_1app_rclone_http_system_quick_test.py and reproduce the missing integrationtest.config_file_gen import using the documented pytest command. Search the other integration tests for similar imports and account for the integrationtest changes before v3.0.1. Done means the affected tests collect and execute instead of stopping with ModuleNotFoundError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.