DUNE-DAQ / DUNE-DAQ/runconftools
[Bug]: Incorrect fail state if the base repo doesn't exist/cannot be accessed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 3d 14h
- Merged PRs (30d)
- 3
Description
Description
Currently when the base repo cannot be found either through not being provided or from git permissions issues this does not get caught usefully.
Instead finally block causes self.repo to be None/not set which results in a confusing crash
None type has no attribute remotes
https://github.com/DUNE-DAQ/runconftools/blob/develop/src/runconftools/ConfPool.py#L26-L37.
Fix to is to simply remove the finally statement as any other error will be meaningfully caught with this removed.
Steps to reproduce
- Provide any incorrect base repo at initialisation
Version and environment
[All DAQ versions since release]
Impact
Small/Isolated
Anything else?
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/runconftools/ConfPool.py at lines 26-37 and trace initialization with a missing or inaccessible base repository. Reproduce the issue using an incorrect base repo and confirm the resulting error is meaningful rather than a NoneType remotes crash. Done means the failure is handled clearly for both omitted and inaccessible repositories.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100