DUNE-DAQ / DUNE-DAQ/integrationtest

[Enhancement]: Convert the log_file_checks to support pytest.fail reports

Open
#170 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
0
Forks
2
Avg merge
1m
Merged PRs (30d)
1

Description

Description

As part of reviewing DUNE-DAQ/daqsystemtest#335, Michal mentioned that the 'failure end block' did not give much information about what the problem was when the integtest failed.

This ties in with Eric's suggestion that we convert our assert calls in integtests when problems occur to pytest.fail calls which can provide more useful information than just a boolean (DUNE-DAQ/daqsystemtest#298).

This Issue requests that we use the 3ru_3df_multirun_test to develop this functionality in the log_file_checks that are included in the integrationtest infrastructure. The goal would be to provide some useful information in the 'failure end block' about what the problem was.

Potential impact radius

Medium

Reason for change

The goal of the change would be to make integtest failures more easy to recognize and understand.

Suggested implementations

See DUNE-DAQ/daqsystemtest#298.

Testing suggestions

No response

Anything else?

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the 3ru_3df_multirun_test and trace the log_file_checks used by the integrationtest infrastructure. Review DUNE-DAQ/daqsystemtest#298 for the proposed pytest.fail approach, then determine how the failure end block should report the underlying problem and add coverage for the resulting failure information.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.