DUNE-DAQ / DUNE-DAQ/integrationtest
[Enhancement]: check the return code from the set_connectivity_service_port function
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 2
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Description
It seems like it would be a good idea to check whether the call to set_connectivity_service_port succeeded in integrationtest_drunc.py and react accordingly if it didn't.
Potential impact radius
Small/Isolated
Reason for change
I suspect that at the moment, if the set_connectivity_service_port script fails, the running of integrationtests continues, and users may not notice that there was a problem. It would be good to alert users of problems.
Suggested implementations
TBD
Testing suggestions
Once we add error checking, we can locally modify to code to return an error and see the error message(s) that users will set.
Anything else?
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in integrationtest_drunc.py at the call to set_connectivity_service_port and inspect how its return status is currently handled. Force the script to return an error locally, then verify that integration tests alert users or react appropriately instead of continuing silently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100