DUNE-DAQ / DUNE-DAQ/hermesmodules
`hermesmodules` needs to drop usage of `NICInterface.hpp` header
A pull request for this has already been merged.
- #29 by @jcfreeman2 — merged
- Dominant language
- C++
- Stars
- 0
- Forks
- 1
- Avg merge
- 7h 20m
- Merged PRs (30d)
- 3
Description
Currently we can expect the v5 nightly to fail (https://github.com/DUNE-DAQ/daq-release/actions/runs/9552875219) since HermesModule.cpp has the line #include "appmodel/NICInterface.hpp" but NICInterface got dropped from appmodel code generation. Not sure what the exact solution here is (it's not obviously a simple matter of a name change as far as I can tell), but changes should be made so this will once again compile.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with HermesModule.cpp and its include of appmodel/NICInterface.hpp, then inspect the appmodel generated interfaces to understand what replaced NICInterface. Reproduce the failure using the v5 nightly workflow linked in the issue; done means the hermesmodules code compiles successfully without that removed header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100