DUNE-DAQ / DUNE-DAQ/hermesmodules
The `Placeholder_test` should be replaced with real unit testing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 1
- Avg merge
- 7h 20m
- Merged PRs (30d)
- 3
Description
i.e., we should improve on line 61, the auto-generated skeleton unit test code created by create_dunedaq_package:
daq_add_unit_test(Placeholder_test LINK_LIBRARIES ${PROJECT_NAME}) # Placeholder_test should be replaced with real unit tests
Along with the benefits of unit testing, making this change will ensure that this can build in a work area even if other packages have this issue. Otherwise you'll see this error:
target with the same name already exists. The existing target is an
executable created in source directory
"/home/nfs/jcfree/daqbuild_feb27/sourcecode/hermesmodules". See
documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
crtmodules/CMakeLists.txt:49 (daq_add_unit_test)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the generated package CMakeLists.txt around line 61 and the crtmodules/CMakeLists.txt call site shown in the error. Replace the Placeholder_test entry with real unit-test coverage for the package, then build the packages together to confirm the duplicate target error is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100