DUNE-DAQ / DUNE-DAQ/fdreadoutlibs
Could locally defined timestamp_t in readout code be replaced with daqdataformats::timestamp_t?
Open
@roland-sipos is already working on this.
Since Apr 26, 2023.
enhancement
- Dominant language
- C++
- Stars
- 0
- Forks
- 3
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 5
Description
I noticed that several of our FrameProcessor, etc. files use a locally declared "using" statement to define a local timestamp_t data type rather than using daqdataformats::timestamp_t.
Could this be changed so that we don't have multiple definitions of timestamp_t?
./ssp/SSPFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wibeth/WIBEthFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEStreamFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./daphne/DAPHNEFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/SWWIBTriggerPrimitiveProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib/WIBFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/WIB2FrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/SWWIBTriggerPrimitiveProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./wib2/RAWWIBTriggerPrimitiveProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
./tde/TDEFrameProcessor.hpp: using timestamp_t = std::uint64_t; // NOLINT(build/unsigned)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.