DUNE-DAQ / DUNE-DAQ/fdreadoutlibs
Look into initializing m_previous_seq_id in WIBEthFrameProcessor.cpp at the start of each run
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 0
- Forks
- 3
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 5
Description
This was discussed at the 23-Oct-2024 Core Software WG meeting.
At that time, Roland suggested that it would be good to initialize this variable at the start of each run, or at least provide a "first-check" boolean that would skip the testing of the current sequence ID the first time through the sequence_check() code.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read WIBEthFrameProcessor.cpp and locate m_previous_seq_id and sequence_check(). Trace how a run starts and how the current sequence ID is checked, then determine whether initialization at run start or a first-check guard matches the intended behavior. Done means the selected behavior is implemented and its sequence-check behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100