DUNE-DAQ / DUNE-DAQ/drunc

[Feature]: Simplify the failure mode tests

Open
#993 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement Testing
Dominant language
Python
Stars
3
Forks
5
Avg merge
2d 11h
Merged PRs (30d)
10

Description

Description

The failure mode tests introduced in https://github.com/DUNE-DAQ/drunc/pull/868 are very schematic, and could do with simplification, to minimize future maintenance.

If not possible to group these files into a single one with importable testing methods, at least import the relevant tests and write them more cleanly.

Potential impact radius

Small/Isolated

Reason for change

Don't want to have to maintan many instances of basically the same code on repeat

Suggested implementations

Wrappers with pytest groupings

Testing suggestions

The change should continue to run the same tests, but be much more compact.

Anything else?

N/A.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the failure mode test files introduced by pull request #868 and compare their repeated structure. Start by checking how the tests are currently invoked, then consolidate or wrap the repeated cases with pytest groupings while preserving the same test coverage and behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.