Duplicated definitions in headers
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 0
- Forks
- 1
- Avg merge
- 5h 38m
- Merged PRs (30d)
- 4
Description
There are duplicated definitions of
#define RX_RING_SIZE 1024
#define TX_RING_SIZE 1024
#define NUM_MBUFS 8191
#define MBUF_CACHE_SIZE 250
EALSetup.hpp and DPDKDefinitions.hpp
We need to clean it up and stick with one. Also, these should be const expressions?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the definitions in EALSetup.hpp and DPDKDefinitions.hpp, starting with where RX_RING_SIZE, TX_RING_SIZE, NUM_MBUFS, and MBUF_CACHE_SIZE are used. Done means the duplicated definitions are consolidated into one location and the issue of making them const expressions is resolved consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100