DUNE-DAQ / DUNE-DAQ/dpdklibs

Awkward NIC Metric To OpMon Assignment

Open
#144 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
0
Forks
1
Avg merge
5h 38m
Merged PRs (30d)
4

Description

https://github.com/DUNE-DAQ/dpdklibs/blob/a78a6d89ff72fa8b2de1ce7fe1ee964d4f21dbe1/src/IfaceWrapper.cpp#L341-L361

The NIC metrics grabbed by rte_ethdev.h are dependent on the NIC installed to a machine, so this is expected to vary with upgrades, detector servers, etc. However, the assignment to OpMon is direct and is not necessarily tuned to an arbitrary NIC. This results in missed OpMon metric assignment in the case of slight naming differences or a regular emission of warnings for a NIC metric that is not defined in OpMon.

We are likely not interested in tracking all possible NIC metrics, so we should define the set of metrics we are interested in and define them in the OpMon metrics. The translation between NIC and OpMon metrics would then need to be robust to slight naming differences.

An immediate quality-of-life improvement would be to emit these warnings only once instead of every metric poll.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/IfaceWrapper.cpp at lines 341-361 and inspect how rte_ethdev.h NIC metrics are assigned to OpMon. Define the metrics to track, make the NIC-to-OpMon translation tolerate naming differences, and ensure warnings for unavailable metrics are emitted only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.