DUNE-DAQ / DUNE-DAQ/dpdklibs

Factorize iface_init

Open
#102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement miscellaneous deliverable
Dominant language
C++
Stars
0
Forks
1
Avg merge
5h 38m
Merged PRs (30d)
4

Description

Instead of the iface_init "god function" , we should factorize it's content in the already existing RTEIfaceSetup.hpp header to manipulate interface interactions.

The list of functions to be implemented in RTEIfaceSetup and to break them out from iface_init, are the following:

  • Get interface validity
  • Get iface info (scattered around in iface_init already for different fields)
  • Iface reset
  • Configure MQ RSS and offloading capabilities
  • Iface configure
  • Set MTU
  • Adjust, configure, allocate RX/TX rings
  • Start/stop iface ( mentioned already in #87 )

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating iface_init and reading the existing RTEIfaceSetup.hpp header to map the interface setup responsibilities already scattered across the function. Compare the listed operations with the header's current API; done means those operations are factored out into RTEIfaceSetup and iface_init no longer acts as the god function.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.