DUNE-DAQ / DUNE-DAQ/daqsystemtest

[Feature]: create a focused check on the time it takes for the scrap transition

Open
#340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
1
Forks
0
Avg merge
3d 1h
Merged PRs (30d)
9

Description

Description

Claudia noticed that the existing check in the small_footprint_quick_check on whether the DAQ session runtime is too long does not handle well the use of the k8s process manager (e.g. see here).

In a separate PR, I'm going to advocate that we remove that check from the SFQT, and the intention of this Issue is to request that we create a more focused check on the time that it takes for the scrap transition to complete.

  • recall that the reason for a check on the time of the scrap transition was that there has been a code change that increased the time that it takes to complete, but we didn't notice that right away. And, I felt that it would be good to notice such changes sooner.
  • and, the expedient way of implementing such a check was to measure the overall DAQ runtime, but that was too broad.

For reference, the DAQ session run time in the SFQT test was around 50-53 seconds a few weeks ago. That increased to 57-60 seconds with the addition of the user-specified multiple-control-process changes in integrationtest, and when I additionally request that the k8s process manager gets used, the time goes up to 68-69 seconds.

Potential impact radius

Small/Isolated

Reason for change

Create a more robust measurement of the scrap transition time.

Suggested implementations

One option that comes to mind is to add drunc "echo" statements to the list of dunerc_commands in the small_footprint_quick_test before and after the scrap transition is run, and then examine the timestamps in the output of the drunc output to determine how long the scrap transition took.

Testing suggestions

No response

Anything else?

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the small_footprint_quick_test and its dunerc_commands, then inspect the existing small_footprint_quick_check that measures overall DAQ runtime. Use the drunc output around the scrap transition to measure that transition specifically, and run the SFQT with the k8s process manager to verify the focused check reports the intended timing without depending on total session runtime.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, python
Domain
performance, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.