DTStack / DTStack/molecule

bug: groupId can't be undefined on onCloseTab

Open
#840 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
970
Forks
141
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

```diff
- IEditorService.onCloseTab(callback: (tabId: UniqueId, groupId?: UniqueId | undefined) => void): any
+ IEditorService.onCloseTab(callback: (tabId: UniqueId, groupId: UniqueId) => void): any
```

### Versions

- OS:
- Browser:
- Molecule: 1.3.0

### To reproduce

### Expected

### Actually happening

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.