DReichLab / DReichLab/waldo

Sample is_control

Open
#168 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The current implementation checks only the control letter. This is mostly correct. Newer controls do not bother to create fake samples.

The problem arises from collaborator products (at least extracts) sent that were processed normally and given sample numbers. Some of these are actually controls, for example: S25321.

Proposal:
Validate sample by checking that all layout elements corresponding to a sample at all stages (lysate, extract, library, capture) agree on control type.
Compute by returning control type of any layout element.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the current sample validation and the control-letter check. Review how layout elements are represented across lysate, extract, library, and capture stages, then determine how their control types are exposed. Done means sample validation checks agreement across all corresponding layout elements, including collaborator products such as S25321.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.