DReichLab / DReichLab/waldo

Powder Sample is_control

Open
#167 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

return self.powder_sample_id.endswith('NP')

This implementation appears wrong for the database contents.

Not sure if there is an existing powder sample object for a control that does not end in NP.

S20753.NP This is a part of minimally destructive extraction experiment
S20741a.NP This is actually a control

NP appears to be used basically only for this batch now.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the code containing return self.powder_sample_id.endswith('NP') and inspect the powder sample records represented by S20753.NP and S20741a.NP. Determine the intended control classification from the database contents, then verify that the behavior for these examples is covered before considering the issue complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.