DReichLab / DReichLab/EIG

obsolete finite function

Open
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
207
Forks
61
PR merge metrics
No merged PRs in 30d

Description

OS X 13.5
Apple clang version 14.0.3
finite appears to be obsolete and needs to be replaced by the C99 macro isfinite.

We should probably be able to replace this for all platforms.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the C sources for uses of the obsolete finite function and review how those calls are built on the reported OS X and other platforms. Replace the obsolete usage with the C99 isfinite macro where appropriate, then verify that the project builds successfully across the supported platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.