DOI-USGS / DOI-USGS/streamMetabolizer

predict_metab omits MLE errors

Open
#380 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Stan
Stars
47
Forks
25
PR merge metrics
No merged PRs in 30d

Description

For an MLE model where some days have been excluded (e.g., for `NAs in DO.obs`)
```r
predict_metab(mm)
```
yields a data.frame where the `errors` column is NA whenever a day is excluded, rather than reporting on the reason for the exclusion. In contrast,
```r
get_fit(mm)
```
for that same model gives the appropriate errors in the `errors` column.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the example with an MLE model containing excluded days, then inspect predict_metab(mm) and compare its errors handling with get_fit(mm). Done means predict_metab reports the exclusion reasons in its errors column instead of NA, consistently with get_fit.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.