DOI-USGS / DOI-USGS/streamMetabolizer

improve predict_DO output for pi, oipi, and sim models

Open
#330 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Stan
Stars
47
Forks
25
PR merge metrics
No merged PRs in 30d

Description

see also #294 (for plots specifically): DO predictions for non-oi-only models require different methods from oi-only models.
- [ ] `predict_DO.metab_bayes` should make use of `err_proc_iid`, `DO_mod`, etc. if these are tracked and stored; otherwise they should give a message or warning describing how close we can get, or not, with the available information
- [ ] `predict_DO.metab_model` and `mm_predict_DO_1ply` use err.obs=err.proc=0 right now. they should use errors determined during the model fit, shouldn't they?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.