DOI-USGS / DOI-USGS/pywatershed
Bug Control handling of PRMS legacy fields
- Dominant language
- Fortran
- Stars
- 54
- Forks
- 25
- Avg merge
- 14h 56m
- Merged PRs (30d)
- 10
Description
`nhruOutBaseFileName` and `nsegmentOutBaseFileName` are handled as if they are equal and also as if they are directories. I think this I the correct way to handle them, but it should be enforced by checking they are identical and end with a `/`.
`nhruOutVar_names` and `nsegmentOutVar_names` can apparently be `"none"` in the file. Should make sure this is not causing problems.
Contributor guide
Research direction
No file or test is named in the issue. Locate the handling of `nhruOutBaseFileName`, `nsegmentOutBaseFileName`, `nhruOutVar_names`, and `nsegmentOutVar_names`, then inspect how the legacy fields are parsed. Done means mismatched or non-directory base names are rejected or handled consistently, and `"none"` variable names do not cause problems, with tests covering those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100