DOI-USGS / DOI-USGS/pyPRMS

control: ability to roundtrip partial control files

Open
#39 1 comment 0 reactions 1 assignee Claimed by @pnorton-usgs View on GitHub
enhancement
Dominant language
Python
Stars
12
Forks
9
Avg merge
2m
Merged PRs (30d)
1

Description

A concrete instance:
`prms_warmup` option has default of zero (in 5.2.1) but the default in pyPRMS is set 1. I have a control file without `prms_warmup`, round tripping the file causes output differences in the runs for runs longer than one year.

It sounds like updating the default in pyPRMS to the value in 5.2.1+ is good.

I see why populating all the control variables is desirable but it is also desirable to be able to roundtrip partial/incomplete control files. An option to do `complete` or maybe `roundtrip` mode on `.init()` could simply collect the keys and then delete these from the Control object before returning.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.