DOI-USGS / DOI-USGS/loadflex

Remove all unnecessary code from aggregateSolute

Open
#220 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
16
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Issue #199 and PR #219 are converting `aggregateSolute` to an internal function (deprecated for external use) and avoiding using it for uncertainty calculations. This is avoidance is appropriate even if someone doggedly keeps calling it as `loadflex:::aggregateSolute`, so I think we can take out a ton of the code currently in this function. A minimal function is a maintainable function. Arguments that are no longer necessary can be removed, leaving in a `...` argument, then checking `...` for named arguments that have been removed and giving an informative warning about them.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.