DOI-USGS / DOI-USGS/hyRefactor

sp/sf conversion failing in reconcile_catchment_divides

Open
#37 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

I just updated `hyRefactor` and a new error is spit out on every iteration of `reconcile_catchment_divides`

`par_split_cat() on pid: 17245 catchment: 9534491
Error : [as,sf] coercion failed. You can try coercing via a Spatial* (sp) class`

I _think_ this is because `fid` needs to be called with `!!` [here](https://github.com/dblodgett-usgs/hyRefactor/blob/e53d8ab606b427cb2a6e4f70e0cc80b152fc2351/R/reconcile.R#L342) and when its not the filter is returning no results.

I will send this as a very small PR if that assumption holds.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.