DOI-USGS / DOI-USGS/ale

tkfram and zzdynrot matrix order issue

Open
#552 4 comments 0 reactions 1 assignee Claimed by @Kelvinrr View on GitHub
Dominant language
XC
Stars
18
Forks
38
Avg merge
1d 20h
Merged PRs (30d)
3

Description

A SpiceyPy user recently opened an issue (https://github.com/AndrewAnnex/SpiceyPy/issues/473) to report that `tkfram` was returning a incorrectly transposed rotation matrix. I identified this issue to be due to the use of the direct c converted fortran spice functions and that the `zzdynrot` was also likely effected, while other similar fortran functions (irfrot etc) were not effected. After looking into this further, both zzdynrot and tkfram were added via a pull request to support ALE in 2019 https://github.com/AndrewAnnex/SpiceyPy/pull/301, so this bug has been lurking in the codebase for a while.

I currently have a pull request https://github.com/AndrewAnnex/SpiceyPy/pull/474 that includes the fixes, but this project should evaluate the degree to which they are impacted by this change.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.