DOI-USGS / DOI-USGS/ale

Better handle ISIS Camera Version information attachment

Open
#458 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
XC
Stars
18
Forks
38
Avg merge
1d 20h
Merged PRs (30d)
3

Description

Currently if there is no information in ["IsisCube"]["Kernels"]["CameraVersion"] in the incoming label, ALE fails [here](https://github.com/USGS-Astrogeology/ale/blob/306a6d8429ceed24952e375e13be13aa945e19a5/ale/base/label_isis.py#L72) and ISIS handles the spiceinit. However, since Camera Version is ISIS camera version information, I don't think failing is the proper way to handle this because no raw mission EDR label will have this information.

Looking into how ISIS handles this, it seems spiceinit calls CameraFactory::CamerVersion [here](https://github.com/USGS-Astrogeology/ISIS3/blob/bea365e49480a74620a8ae69171a143d316a28f7/isis/src/base/apps/spiceinit/spiceinit.cpp#L451) which looks for a Camera plugin file (either local or at location $ISISROOT/lib/Camera.plugin) to inform the ISIS camera version.

We could duplicate this logic, since ALE is typically used WITH ISIS we could assume this plugin file exists exactly the same as ISIS does? I am really curious to hear other's thought because I am not well versed in ALE big picture architecture.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.