Depricate `ShapeModel` classes public facing `setHasIntersection` function
Open
breaking
- Dominant language
- C++
- Stars
- 245
- Forks
- 181
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 15
Description
Anyone directly using the `ShapeModel` class in ISIS should not be able set whether there is a surface intersection on the model.
Any `ShapeModel` in ISIS should determine whether an intersection is present internally and not expose that determination to outside programs modifying the state of the `ShapeModel`.
Contributor guide
Research direction
Locate the ShapeModel classes and every declaration or use of the public setHasIntersection function. Read how each ShapeModel determines surface intersections internally, then verify that external callers can no longer change that state while existing intersection behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100