DOI-USGS / DOI-USGS/ISIS3

Tests take too long

Open
#5,748 5 comments 0 reactions 0 assignees View on GitHub
bug inactive
Dominant language
C++
Stars
245
Forks
181
Avg merge
1d 22h
Merged PRs (30d)
15

Description

**ISIS version(s) affected**: Latest

ISIS has about 2700 tests. When some take a long time, it is very time consuming to update them, especially that many iterations may be needed.

Some were fixed recently. Here are the tests that now take the longest, based on the run in the cloud.

2676/2676 Test #1469: DefaultCube.FunctionalTestCaminfoCsv Passed 1123.13 sec
2376/2676 Test #1007: hijitter_app_test_withCrop ***Failed 721.48 sec
2675/2676 Test #1470: DefaultCube.FunctionalTestCaminfoDefault Passed 696.16 sec
2173/2676 Test #1006: hijitter_app_test_default ***Failed 681.63 sec
2674/2676 Test #1307: TempTestingFiles.UnitTestImagePolygonCross ***Failed 619.01 sec
1195/2676 Test #892: juno_module_test_junocam Passed 284.63 sec
1375/2676 Test #1044: thmproc_app_test_vis ***Failed 177.01 sec
1792/2676 Test #1589: DefaultCube.UnitTestImagePolygonBoundary Passed 114.78 sec
2449/2676 Test #2080: Kerneldbgen.FunctionalTestKerneldbgenExtraDefault Passed 111.66 sec
1791/2676 Test #1593: LineScannerCube.FunctionalTestCamdevDefault Passed 106.83 sec

At least the first five should be optimized somewhat, as waiting for 10-20 minutes for a test to fail is likely too long.

Contributor guide

Open the contributing guide

Research direction

Start with the five longest tests listed in the issue: DefaultCube.FunctionalTestCaminfoCsv, hijitter_app_test_withCrop, DefaultCube.FunctionalTestCaminfoDefault, hijitter_app_test_default, and TempTestingFiles.UnitTestImagePolygonCross. Run them individually to identify where their time is spent and inspect the corresponding test entry points. Done means the tests complete substantially faster without losing coverage or correctness, though the issue gives no precise runtime target.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.