DNNCommunity / DNNCommunity/PolyDeploy

Removing the UseTaskFriendlySynchronizationContext key on uninstall breaks other modules

Open
#9 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
51
Forks
20
PR merge metrics
No merged PRs in 30d

Description

Removing the `aspnet:UseTaskFriendlySynchronizationContext` key from the `web.config` on module uninstall breaks other modules installed on my DNN site that require the use of the key.

Can we just add the key on install if it's not already present in the `web.config` and then not remove it on uninstall. As there's no way to tell if it was already present / if anything else uses the key.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.