DIRACGrid / DIRACGrid/Pilot

Purging variables in pilotCommand installEnv

Open
#156 3 comments 0 reactions 0 assignees Claimed by @psgebeli View on GitHub
Dominant language
Python
Stars
5
Forks
26
Avg merge
24m
Merged PRs (30d)
1

Description

As far as I can tell the GFAL (etc.) variables survive the purging by the diracos2/diracosrc because the original environment is kept from the start
https://github.com/DIRACGrid/Pilot/blob/2a1dc97fc395520a0e19bf0328dba5c9a53dc0c0/Pilot/pilotTools.py#L528
And then only updated with the new values from diracosrc obtained here
https://github.com/DIRACGrid/Pilot/blob/2a1dc97fc395520a0e19bf0328dba5c9a53dc0c0/Pilot/pilotCommands.py#L307
updating installEnv dict
https://github.com/DIRACGrid/Pilot/blob/2a1dc97fc395520a0e19bf0328dba5c9a53dc0c0/Pilot/pilotCommands.py#L316
but non-existing values are not popped
and then the jobagent runs with installEnv
https://github.com/DIRACGrid/Pilot/blob/2a1dc97fc395520a0e19bf0328dba5c9a53dc0c0/Pilot/pilotCommands.py#L1053

Should we just `self.pp.installEnv = {}` before filling updated values?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.