DIRACGrid / DIRACGrid/DIRAC

job status transition in ReqClient vs JobStatus

Open
#7,799 8 comments 0 reactions 0 assignees View on GitHub
WMS
Dominant language
Python
Stars
126
Forks
191
Avg merge
1d 13h
Merged PRs (30d)
33

Description

This code suggests transition of job status from 'Completed' to 'Killed'
https://github.com/DIRACGrid/DIRAC/blob/v8.0.51/src/DIRAC/RequestManagementSystem/Client/ReqClient.py#L371-L373
```
if jobStatus == JobStatus.COMPLETED:
...
elif jobMinorStatus == JobMinorStatus.MARKED_FOR_TERMINATION:
# If the job has been Killed, set it Killed
newJobStatus = JobStatus.KILLED
...
stateUpdate = stateServer.setJobStatus(jobID, newJobStatus, JobMinorStatus.REQUESTS_DONE, "RMS")
```

but there is no such state transition defined in
https://github.com/DIRACGrid/DIRAC/blob/v8.0.51/src/DIRAC/WorkloadManagementSystem/Client/JobStatus.py#L88
```
COMPLETED: State(11, [DONE, FAILED], defState=COMPLETED),
```

Which is the policy?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.