DHI / DHI/modelskill

Problems with match() (flooding/drying)

Open
#506 11 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
56
Forks
9
Avg merge
57m
Merged PRs (30d)
3

Description

Hi,

I'm experiencing a bug with the `match()` function. Sometimes, I get an error in the function`_get_global_start_end()` defined in matching.py. My understanding is that this function checks the begin and end times of the model results passed to it and defines those as the "period" to match the observations.

When trying to match, I sometimes get an `AssertionError` in the following line:

`` assert all([len(x) > 0 for x in idxs])``

The model results are of type `DfsuModelResult` and the observations are of type `PointObservation`. Both have well-defined start and end times, but they do not overlap perfectly.

Is there something I'm missing here?

Best regards,

Victor

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.