DHI / DHI/mikecore-python

eum.py: ~120 lines of commented-out, half-translated EUM filter API stubs — port or delete

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

`mikecore/eum.py` carries roughly 120 lines of commented-out, half-translated C# declarations — from about line 1904 to about line 2025 — each carrying a `# TODO: Pending` marker. Nine of the module's TODOs live inside them. They look like this:

```python
# #/
# #/ TODO: Pending
# #/
# @staticmethod
# def eumGetFilterCount(); -> int:
#
# private static bool _eumGetFilterSeq(SeqNo: int, out FtKey: int, out IntPtr lpFtDesc);
```

They are not valid Python even uncommented — the signatures are a mix of Python and C# (`def eumGetFilterCount(); -> int:`, `private static bool`, `out IntPtr`), so they are a transcription of the original API surface rather than code that ever ran.

The affected group is the EUM filter/sequence family (`eumGetFilterCount`, `eumGetFilterSeq`, and neighbours).

Worth deciding once, either way:

- **Port them**, if anything needs to enumerate EUM filters from Python; or
- **Delete them**, and note in the module docstring that the filter API is not wrapped.

Either outcome removes nine TODOs and about 120 lines of noise from the largest module in the package. Leaving them is the only option that keeps implying work is planned when none is.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the commented EUM filter/sequence block in mikecore/eum.py around lines 1904–2025 and the surrounding wrapped API to determine whether Python callers need filter enumeration. Done means either replacing the declarations with valid Python wrappers or removing the block, its nine TODOs, and documenting the unwrapped filter API in the module docstring.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.