DFE-Digital / DFE-Digital/check-performance-data
[Bug] Mandatory evidence shown as optional in Not on roll > Other journey
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 0
- Forks
- 1
- Avg merge
- 19h 21m
- Merged PRs (30d)
- 54
Description
Overview
When a user navigates through the Remove student > Not on roll > Other journey the evidence screen is displayed which contains the text (optional) however, the evidence at this point is mandatory.
Evidence is optional for the other three options for Not on roll: Apprentice, External candidate, International student.
This is also the case when going through the Remove student > Other journey.
Steps to reproduce
- Navigate to DEV or QA and sign in.
- Click Continue on one of the checking windows.
- Select the checkbox for Request an amendment to student data and click Continue.
- Select the checkbox for Remove a student from data and click Continue.
- Enter the name of a student, select a student, and click Continue.
- Select the checkbox for Not on roll and click Continue.
- Select the checkbox for Other and click Continue.
- Note that the evidence page displays containing the word Optional in the upload and text entry sections.
- Without entering any evidence data click Continue.
- Note that an error displays informing the user that evidence needs to be entered.
Screenshots
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the Remove student > Not on roll > Other and Remove student > Other journeys in DEV or QA, then trace the evidence screen and its validation. Update the affected journeys so the label reflects that evidence is mandatory, while the other Not on roll options remain optional; verify that continuing without evidence is rejected only where required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100