DFE-Digital / DFE-Digital/check-performance-data

[A11y] 4.1.2 Name, Role, Value – Redundant hidden instructions on Provide Evidence

Open
#389 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
0
Forks
1
Avg merge
19h 21m
Merged PRs (30d)
54

Description

Split from #381, which reported five separate problems under one ticket.

Tester has observed that on the 'Provide Evidence' page, the user is directed to hidden instructions, which are redundant because the instructions are already visible on the page.

This does not comply with WCAG Level A 2.2:
4.1.2 Name, Role, Value - https://www.w3.org/WAI/WCAG22/Understanding/name-role-value.html

Steps to Recreate:

  1. Navigate to URL
  2. Navigate to the file upload control with a screen reader enabled
  3. Observe issue

This has been observed on the following pages:

  • Provide Evidence

Environment:
Windows 11 - Chrome 151 - JAWS (desktop screen reader)

Reproduction rate:
100% - Consistently reproducible.

Supporting material:
Video: https://drive.google.com/drive/folders/1Ph21Q5-UlnfnvKJ1zQQA-K5uM-WY14X2?usp=sharing

Version: https://check-performance-data-preproduction.teacherservices.cloud/

2.Major Impact on Accessibility


Where to look: the file input in Views/Journey/_FileUpload.cshtml sets aria-describedby (built by QuestionPartialModel.DescribedBy) pointing at #fileUpload-hint, which is the same hint text shown on screen. Repeating a visible hint through aria-describedby is the standard GOV.UK pattern, so confirm with the auditor which text is actually duplicated before removing anything. Note the rule in docs/accessibility.md: aria-describedby may only name ids that are rendered, so the id list and the markup must change together.

Priority: High
DoneDone issue: https://zoonou.mydonedone.com/issuetracker/projects/91343/issues/8

Parent: #373. Split from: #381

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the file input in Views/Journey/_FileUpload.cshtml and review how QuestionPartialModel.DescribedBy builds aria-describedby for #fileUpload-hint. Read docs/accessibility.md, confirm with the auditor which text is duplicated, and keep the id list and rendered markup consistent. Done means the redundant instruction is resolved without referencing an unrendered id.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.