DDMAL / DDMAL/mothra

Changes in .csv mapping file that have to be corrected/changed

Open
#310 6 comments 0 reactions 0 assignees View on GitHub
bug encoding Priority: medium
Dominant language
Python
Stars
0
Forks
2
Avg merge
10h 52m
Merged PRs (30d)
42

Description

While fixing these issues (https://github.com/DDMAL/mothra/issues/295, https://github.com/DDMAL/mothra/issues/273, https://github.com/DDMAL/mothra/issues/257) @giannatan made changes to the .csv mapping file. She's sent me a detailed list of the changes she made, and some of them are correct, some are not, and some are things that need to be discussed.

Square notation

| Change | Comment |
| ------- | ------- |
| added alternate F clef | Error: there shouldn't be an alternate F clef for square notation |
| divisio maior + finalis added | Correct |
| width column changed from [1, 1]/2/1 to [2] (single shared column instead of two separate ones) for podatus, pes cephalicus, obilque, as both components share one column | This is correct for the podatus2b and the oblique, but not for the pescephalicus and podatus2a |
| scandicus 22b/22c width changed from [2, 1] and [1, 1, 1] respectively to [1, 2] for both | Error: the scandicus22b and 22c have different widths because they look different. The original widths are correct. |

Hufnagel notation

| Change | Comment |
| ------ | ------ |
| Added divisio finalis | Correct |
| width changed from [1, 1] to [2] for podatus and clivis (-> single shared column) | Error: both of these neumes have a width of [1, 1] in Hufnagel, unless the clivis2a needs to have a width of [1] because the elements are ligated. This change explains the podatus error in #295; the width is wrong because the mapping file is wrong |
| ligature encoding fixed for clivis2a-5a by replacing con="e" with ligated="true" on both nc elements | This is correct for now, but won't be later. See https://github.com/DDMAL/Neon/issues/1366 |
| torculus22/23/etc. changed width to [1, 2] (last two components now share a column), con="e" on third nc replaced with ligated="true" for ligation to actually show up in neon | Same as above |

@giannatan where did you get your mapping files? Some of the elements you added are already in mine, so I'm worried there are alternate versions floating around.

It's very important that all of our mei mapping files, in mothra and our various resources repos, match exactly. I suggest we don't make more changes until @giannatan, @zih-syuan and I have confirmed that my comments above are correct and work properly. Once that's done, we can make a definitive mapping file and make absolutely sure that all our files are updated! Once Neon is updated to accept `con="e"`, we'll have to update the mapping file again.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.