DDMAL / DDMAL/cantus

Volpiano and quoted cached search terms have bugs

Open
#769 0 comments 0 reactions 0 assignees View on GitHub
Bug Low Priority Search
Dominant language
JavaScript
Stars
16
Forks
4
Avg merge
2d 16h
Merged PRs (30d)
3

Description

When you navigate back to search field where you've previously made a search, the most recent search in that field is displayed.

For example, if you search "alleluia" in the `All Text Search`, then search for a feast, and then return to `All Text Search`, you should see the search results for "alleluia" and "alleluia" should be in the search input box.

In the case of volpiano searches, the caches searches have escape characters in them (these escape characters are added before passing the search to solr because hyphens are reserved characters in solr's query syntax if not escaped.

![image](https://github.com/DDMAL/cantus/assets/11023634/c349b139-1973-4fbb-b097-99e73a9b6211)

In the case of text searches, cached search strings are not initialized in the search input box if they contain quotation marks.

![image](https://github.com/DDMAL/cantus/assets/11023634/1aa26c22-ec9e-4023-ab80-a0841f6798ea)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start from the cached search restoration for the All Text Search and volpiano search fields, then inspect how cached values are placed into the input and how search terms are escaped for Solr. Done means returning to either field restores the expected results and displays the original term, including hyphens and quotation marks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.